-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new rendertron app engine instance to prerender atila pages for cheaper #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…la-angular into fix_rendertron_temp
…rendertron error; My theory is that serviceworker might be some how causing CORS errors: Got the following error in console.log: Access to manifest at 'https://atila-7-staging.firebaseapp.com/manifest.json' from origin 'https://render-tron.appspot.com' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.
…-7-staging.appspot for rendering
…base-tools#877 see the github thread for more context: firebase/firebase-tools#877
… instance has been deployed in atila-rendertron
Closing this PR now. Once it has finished deploying in circleci.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use rendertron to prerender Atila because it is good for SEO and social media link previews
Atila App Engine Costs for rendertron are very expensive ($90 month) so we are looking for alternatives
closes Switch from Google App Engine for SEO serverside/pre rendering #79
Create an app engine instance atila-rendertron that has a minimum_instance of zero in order to save costs which we will use to prerender our application
Currently deployed on atila-7-staging.appspot.com, once I get home and can review the code on my macbook pro that we used to create the original rendertron instance on atila-7.appspot.com, then we will replace the atila-7.appspot instance with the new one.
Ignore Below, that was the old way
In the rendertron docs and this tutorial they mention that we can use the demo Rendertron
/render
function, though it's not recommended for productionfirebase deploy --only hosting
from circleci build processcloses Switch from Google App Engine for SEO serverside/pre rendering #79