Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add handler for css files #160

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from
Open

add handler for css files #160

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2d5043
add handler for css files
ray007 Feb 2, 2016
40108d0
add sourceURL if not already present
ray007 Jul 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/basket.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,16 @@
head.appendChild( script );
};

var injectStyle = function( obj ) {
var style = document.createElement('style');
style.type = 'text/css';
style.text = obj.data;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style.appendChild(document.createTextNode(obj.data)) instead of style.text

head.appendChild( style );
};

var handlers = {
'default': injectScript
'default': injectScript,
'css': injectStyle
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better use 'text/css' as key name instead 'css' cause obj.type must equal xhr.getResponseHeader('content-type'), which responsed as 'text/css', of course.

};

var execute = function( obj ) {
Expand Down