http: reset parser.incoming when server response is finished

This resolves a memory leak for keep-alive connections with a naïve approach. Fixes: nodejs#9668
addaleax · Jul 11, 2019 · 609e2c2 · 609e2c2
1 parent ca0884a
commit 609e2c2
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/lib/_http_server.js b/lib/_http_server.js
@@ -603,6 +603,7 @@ function resOnFinish(req, res, socket, state, server) {
   assert(state.incoming.length === 0 || state.incoming[0] === req);
 
   state.incoming.shift();
+  if (socket.parser) socket.parser.incoming = null;
 
   // If the user never called req.read(), and didn't pipe() or
   // .resume() or .on('data'), then we call req._dump() so that the