Set sort column and direction with props

[tdzienniak]

Description

A few sentences describing the overall goals of the pull request's commits.

Please check if the PR fulfills these requirements

• The commit message follows our guidelines: https://github.com/adazzle/react-data-grid/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

#547

What is the new behavior?

Sorting direction can be set with props during grid initialization.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

[coveralls]

Changes Unknown when pulling 35f6085 on tdzienniak:master into ** on adazzle:master**.

[jpdriver]

hey @tdzienniak -- this looks good, but one suggestion: can we use the DEFINE_SORT const from here

https://github.com/adazzle/react-data-grid/blob/master/packages/react-data-grid/src/cells/headerCells/SortableHeaderCell.js#L3

rather than having multiple arrays of possible values?

There's probably also an argument to be made for moving the existing array out of SortableHeaderCell.

My two cents are that sortColumn and sortDirection are in the right place here, but the existing definitions should be moved here too? Sorting should conceptually apply to the whole grid, not just HeaderCells..

[tdzienniak]

I agree. Maybe we can move these definitions to Constants.js or AppConstants.js file?

[lakshmi-ammu]

Hi, i am facing one issue if i want to keep " link" inside the column may i know the process in react data grid.waiting your replay.

[tdzienniak]

@jpdriver now prop type check is using DEFINE_SORT constants from SortableHeaderCell.js file. I think that moving these definition to other file needs separate PR, maybe global refactor of dealing with constant values as these.

[coveralls]

Changes Unknown when pulling 35f6085 on tdzienniak:master into ** on adazzle:master**.

[stevewillard]

What's the status of this PR? I would really like this feature.

[jasonpatt]

Any update on the status of this pull request? This is a needed feature that my team is waiting for.

[coveralls]

Changes Unknown when pulling 86ba455 on tdzienniak:master into ** on adazzle:master**.

[GlebDolzhikov]

Please add this feature to package, this three lines of code, but very important to have it!
I can't install forked version because of multi packages structure of repo(

[tdzienniak]

@jpdriver I can correct any issues with this PR. If there are none, why not merge it? I see that people are interested in this change.

[mgscreativa]

Hi! In my case I'm using meteor to fetch a paginated list. Triggering onGridSort handler calls a subscription that sorts the data server side then publishes the paginated data back to the client. To get that subscription data I must use createContainer HOC.

In my scenario, it will be just cool to have those props to tweak them in my render function, so after subscription is ready, the render function should get the sort order and column and set that on the ReactDataGrid component because the data got sorted on the server.

Please merge this!

Thanks!

[hiredgunhouse]

What is the status of this feature?

[mohitgupta8888]

@malonecj @jpdriver Please add this feature to provide default sortColumn and sortDirection. Thanks.

[mrgurdeep]

@jpdriver @tdzienniak Should you have a suggestion on what change you are expecting. I can make those changes in this PR.

Otherwise we can accept this PR.

[mrgurdeep]

added consts

[coveralls]

Changes Unknown when pulling 2db8015 on tdzienniak:master into ** on adazzle:master**.

[mlmassey]

Please pull this in. Minor change and is a needed feature for my usage

[jimmed]

For those looking to work around this issue without forking the project, you can use React's ref API along with ReactDataGrid's handleSort method, like so:

class MyAwesomeGridWrapper extends Component {

  // ...

  componentDidMount() {
	const { sortColumn, sortDirection } = this.props;
    if (!this.grid || !sortColumn || !sortDirection) return;
	this.grid.handleSort(sortColumn, sortDirection);
  }

  // ...

  render() {
    return (<DataGrid ref={grid => (this.grid = grid)} ... />)
  }
}