New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resources.jsx: remove 'this' from this.$(e.currentTarget) in onFilterClicked() #91

Closed

swashbuck opened this issue Jan 24, 2023 · 1 comment · Fixed by #92

Assignees

Labels

Contributor

swashbuck commented Jan 24, 2023

Subject of the issue/enhancement/features

In onFilterClicked() in resources.jsx, 'this' should be removed from this.$(e.currentTarget).

adapt-contrib-resources/templates/resources.jsx

Line 49 in 0781156

const $clickedButton = this.$(e.currentTarget);

Your environment

adapt-contrib-resources v5.3.3

swashbuck self-assigned this

swashbuck added the bug label

swashbuck added this to adapt_framework: The TODO Board

github-project-automation bot moved this to New in adapt_framework: The TODO Board

swashbuck moved this from New to Assigned in adapt_framework: The TODO Board

swashbuck added a commit that referenced this issue


          #91 Remove this from this.

406cd58

swashbuck mentioned this issue

Fix: Remove unnecessary 'this' from currentTarget (fixes #91) #92

Merged

swashbuck moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board

swashbuck added a commit that referenced this issue


          #91 Remove component__inner class

3df51fd

swashbuck closed this as completed in #92

swashbuck added a commit that referenced this issue


          Fix: Remove unnecessary 'this' from currentTarget, remove component__…

835befc

…inner class (fixes #91)

github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board

github-actions bot pushed a commit that referenced this issue


          Chore(release): 5.3.4 [skip ci]

799467d

## [5.3.4](v5.3.3...v5.3.4) (2023-01-25)

### Fix

* Remove unnecessary 'this' from currentTarget, remove component__inner class (fixes #91) ([835befc](835befc)), closes [#91](#91)

github-actions bot commented Jan 25, 2023

🎉 This issue has been resolved in version 5.3.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot added the released label

oliverfoster removed this from adapt_framework: The TODO Board

github-actions bot pushed a commit to redwoodperforms/adapt-contrib-resources that referenced this issue


          Chore(release): 5.1.0 [skip ci]

94b40be

# [5.1.0](v5.0.0...v5.1.0) (2023-07-10)

### Fix

* _globals schema nesting (adaptlearning#102) ([6343b0d](6343b0d)), closes [adaptlearning#102](https://github.com/redwoodperforms/adapt-contrib-resources/issues/102)
* Add custom types to readme, change 'category' references to 'type' for consistency (fixes adaptlearning#108) ([bbf57a8](bbf57a8)), closes [adaptlearning#108](https://github.com/redwoodperforms/adapt-contrib-resources/issues/108)
* Added gitignore for release automation (adaptlearning#81) ([7c6694c](7c6694c)), closes [adaptlearning#81](https://github.com/redwoodperforms/adapt-contrib-resources/issues/81)
* Added release automation (adaptlearning#80) ([e9b6923](e9b6923)), closes [adaptlearning#80](https://github.com/redwoodperforms/adapt-contrib-resources/issues/80)
* Allow custom types (fixes adaptlearning#103) (adaptlearning#104) ([bfaef6e](bfaef6e)), closes [adaptlearning#103](https://github.com/redwoodperforms/adapt-contrib-resources/issues/103) [adaptlearning#104](https://github.com/redwoodperforms/adapt-contrib-resources/issues/104)
* Bump http-cache-semantics from 4.1.0 to 4.1.1 (adaptlearning#95) ([5ae1de4](5ae1de4)), closes [adaptlearning#95](https://github.com/redwoodperforms/adapt-contrib-resources/issues/95)
* Convert template to JSX (fixes adaptlearning#89) (adaptlearning#90) ([e4e426e](e4e426e)), closes [adaptlearning#89](https://github.com/redwoodperforms/adapt-contrib-resources/issues/89) [adaptlearning#90](https://github.com/redwoodperforms/adapt-contrib-resources/issues/90)
* Header template does not work (fixes adaptlearning#99) (adaptlearning#100) ([55fae85](55fae85)), closes [adaptlearning#99](https://github.com/redwoodperforms/adapt-contrib-resources/issues/99) [adaptlearning#100](https://github.com/redwoodperforms/adapt-contrib-resources/issues/100)
* Labels for resources items are unnecessarily verbose ([6b51bbc](6b51bbc))
* Remove required title from contentobject schema (adaptlearning#98) ([6e27c74](6e27c74)), closes [adaptlearning#98](https://github.com/redwoodperforms/adapt-contrib-resources/issues/98)
* Remove unnecessary 'this' from currentTarget, remove component__inner class (fixes adaptlearning#91) ([835befc](835befc)), closes [adaptlearning#91](https://github.com/redwoodperforms/adapt-contrib-resources/issues/91)
* Semantic release action package versions ([e7d02d4](e7d02d4))
* Typo in template ([d90bd43](d90bd43))
* Update schema $anchor to reference resources (fixes adaptlearning#87) ([930034f](930034f)), closes [adaptlearning#87](https://github.com/redwoodperforms/adapt-contrib-resources/issues/87)
* Version numbers removed from Readme files ([292dd99](292dd99))

### New

* Add click event trigger (solves: adaptlearning#106) (adaptlearning#107) ([0d27f68](0d27f68)), closes [adaptlearning#106](https://github.com/redwoodperforms/adapt-contrib-resources/issues/106) [adaptlearning#107](https://github.com/redwoodperforms/adapt-contrib-resources/issues/107)
* Added contentObject specific resources (fixes adaptlearning#84) (adaptlearning#85) ([4df42fd](4df42fd)), closes [adaptlearning#84](https://github.com/redwoodperforms/adapt-contrib-resources/issues/84) [adaptlearning#85](https://github.com/redwoodperforms/adapt-contrib-resources/issues/85)
* Issue and pr project addition automation (refs adaptlearning/adapt_framework#3315) (adaptlearning#79) ([3657367](3657367)), closes [adaptlearning#79](https://github.com/redwoodperforms/adapt-contrib-resources/issues/79)

### Update

* Add missing aria attribution for tabs (adaptlearning#78) ([f3e3e1b](f3e3e1b)), closes [adaptlearning#78](https://github.com/redwoodperforms/adapt-contrib-resources/issues/78)

### Upgrade

* Bump yaml and semantic-release (adaptlearning#105) ([28b3873](28b3873)), closes [adaptlearning#105](https://github.com/redwoodperforms/adapt-contrib-resources/issues/105)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment