Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to hide type filters #115

Closed
swashbuck opened this issue Apr 8, 2024 · 1 comment · Fixed by #116
Closed

Add option to hide type filters #115

swashbuck opened this issue Apr 8, 2024 · 1 comment · Fixed by #116
Assignees
@swashbuck
Labels
enhancement released

Comments

@swashbuck
Copy link
Contributor

swashbuck commented Apr 8, 2024 •
edited
Loading

Subject of the enhancement

Currently, tabs are displayed that relate to each type of resource (ex. Document, Link). If all resource items have the same type assigned (including an empty value), the tabs will be hidden.

It might be useful to have an explicit option to hide or show the tabs, even when resource item types are set. Currently, it's not immediately clear how to hide the tabs, so something like _areTabsEnabled: true would help with this.

This could be backwards compatible for when courses are configured to hide the tabs via the current method.

Screenshots
@swashbuck swashbuck self-assigned this May 13, 2024
@swashbuck swashbuck moved this from New to Assigned in adapt_framework: The TODO Board May 13, 2024
@swashbuck swashbuck mentioned this issue May 13, 2024
Merged
@swashbuck swashbuck moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board May 13, 2024
kirsty-hames pushed a commit that referenced this issue May 21, 2024
@swashbuck @oliverfoster
New: Add _enableFilters property (fixes #115) (#116)
54c3461 
* Schemas and documentation

* Rework resourcesHasMultipleTypes and move to the controller

* Move filter button column count logic from JSX to JS

* Rework setupFilters for conciseness

* Add enableFilters check, rename property

* Use nullish operator for enableFilters

* Remove enableFilters from content objects schema

* Refactor resourcesHasType, remove from JSX

* Rework resourcesForceDownload and remove from JSX

* Remove _enableFilters default from initResources

* Remove shallow clone of configuredTypes

Co-authored-by: Oliver Foster <oliver.foster@kineo.com>
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board May 21, 2024
github-actions bot pushed a commit that referenced this issue May 21, 2024
@semantic-release-bot
Chore(release): 5.5.0 [skip ci]
f2b3f16 
# [5.5.0](v5.4.3...v5.5.0) (2024-05-21)

### New

* Add _enableFilters property (fixes #115) (#116) ([54c3461](54c3461)), closes [#115](#115) [#116](#116)

### Upgrade

* Bump ip from 1.1.8 to 1.1.9 (#114) ([ac33cd7](ac33cd7)), closes [#114](#114)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 5.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New: Add _enableFilters property (fixes #115) adaptlearning/adapt-contrib-resources
1 participant
@swashbuck