Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Return correct calculation for presentation components with items (fixes #228) #229

Merged
merged 4 commits into from
Jun 7, 2024
Merged

Fix: Return correct calculation for presentation components with items (fixes #228) #229

merged 4 commits into from
Jun 7, 2024

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Jun 4, 2024 •
edited
Loading

Fix #228

Fix

  • Correctly calculates completion percentage when making presentation components with items complete.

Testing

  1. Install Dev Tools.
  2. Visit a page that contains presentation components with items (e.g. Narrative, Accordion)
  3. Click "Complete page" in Dev Tools
  4. Alternatively, use similar functionality to complete all components on the page.

Expected result

Presentation components with items should show as 100% completed in the PLP drawer.

@swashbuck swashbuck added the bug label Jun 4, 2024
@swashbuck swashbuck self-assigned this Jun 4, 2024
@swashbuck swashbuck marked this pull request as ready for review June 4, 2024 14:18
oliverfoster
oliverfoster requested changes Jun 4, 2024
View reviewed changes
js/PageLevelProgressIndicatorView.js Show resolved Hide resolved
js/PageLevelProgressIndicatorView.js Outdated Show resolved Hide resolved
js/PageLevelProgressIndicatorView.js Outdated Show resolved Hide resolved
swashbuck and others added 3 commits June 4, 2024 08:53
@swashbuck @oliverfoster
Update js/PageLevelProgressIndicatorView.js
3b62ad1 
Co-authored-by: Oliver Foster <oliver.foster@kineo.com>
@swashbuck @oliverfoster
Update js/PageLevelProgressIndicatorView.js
887984b 
Co-authored-by: Oliver Foster <oliver.foster@kineo.com>
@swashbuck @oliverfoster
Update js/PageLevelProgressIndicatorView.js
95cb8e3 
Co-authored-by: Oliver Foster <oliver.foster@kineo.com>
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joe-allen-89 joe-allen-89 merged commit b327bb7 into master Jun 7, 2024
@joe-allen-89 joe-allen-89 deleted the issue/228 branch June 7, 2024 13:48
github-actions bot pushed a commit that referenced this pull request Jun 7, 2024
@semantic-release-bot
Chore(release): 7.8.1 [skip ci]
ebd565b 
## [7.8.1](v7.8.0...v7.8.1) (2024-06-07)

### Fix

* Return correct calculation for presentation components with items (fixes #228) (#229) ([b327bb7](b327bb7)), closes [#228](#228) [#229](#229)
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

🎉 This PR is included in version 7.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@swashbuck swashbuck

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

calculatePercentage issue for components with items
4 participants
@swashbuck @oliverfoster @cahirodoherty-learningpool @joe-allen-89