Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue/2799 Remove redundant behaviour #229

Merged
merged 3 commits into from
Apr 29, 2022
Merged

issue/2799 Remove redundant behaviour #229

merged 3 commits into from
Apr 29, 2022

Conversation

oliverfoster
Copy link
Member

requires adaptlearning/adapt-contrib-core#84
part of adaptlearning/adapt_framework#2799

Changed

  • Switched to components.register from Adapt.register
  • Use offlineStorage, a11y, device and logging directly
  • Switched to equals helper from if_value_equals

@oliverfoster oliverfoster self-assigned this Mar 24, 2022
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

lc-alexanderbenesch
lc-alexanderbenesch approved these changes Mar 30, 2022
View reviewed changes
Copy link

@lc-alexanderbenesch lc-alexanderbenesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

joe-allen-89
joe-allen-89 requested changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove the unused import log from line 8, and duplicate offlineStorage from line 9.

@oliverfoster
Copy link
Member Author

Need to remove the unused import log from line 8, and duplicate offlineStorage from line 9.

Which file? @joe-allen-89

@joe-allen-89
Copy link
Contributor

Need to remove the unused import log from line 8, and duplicate offlineStorage from line 9.

Which file? @joe-allen-89

@oliverfoster should have included that, mediaView.js

@oliverfoster
Copy link
Member Author

Thanks.

@joe-allen-89 joe-allen-89 merged commit b6b6aef into master Apr 29, 2022
@joe-allen-89 joe-allen-89 deleted the issue/2799 branch April 29, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 requested changes

@lc-alexanderbenesch lc-alexanderbenesch lc-alexanderbenesch approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@oliverfoster oliverfoster

Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliverfoster @joe-allen-89 @cahirodoherty-learningpool @lc-alexanderbenesch