Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue/2799 Removed redundant behaviour #144

Merged
merged 3 commits into from
Apr 28, 2022
Merged

issue/2799 Removed redundant behaviour #144

merged 3 commits into from
Apr 28, 2022

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Mar 24, 2022 •
edited
Loading

requires adaptlearning/adapt-contrib-core#84
part of adaptlearning/adapt_framework#2799

Changed

  • Switched to components.register from Adapt.register
  • Removed html() helper for dangerouslySetInnerHtml
  • Direct import of a11y and device
  • Use _shouldShowMarking

@oliverfoster oliverfoster self-assigned this Mar 24, 2022
@oliverfoster oliverfoster added breaking and removed bug labels Mar 24, 2022
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Mar 29, 2022
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

lc-alexanderbenesch
lc-alexanderbenesch approved these changes Mar 30, 2022
View reviewed changes
Copy link

@lc-alexanderbenesch lc-alexanderbenesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

joe-allen-89
joe-allen-89 approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with FW v5.19.2, working as expected.

@joe-allen-89 joe-allen-89 merged commit 38574bc into master Apr 28, 2022
@joe-allen-89 joe-allen-89 deleted the issue/2799 branch April 28, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@lc-alexanderbenesch lc-alexanderbenesch lc-alexanderbenesch approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@oliverfoster oliverfoster

Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliverfoster @cahirodoherty-learningpool @lc-alexanderbenesch @joe-allen-89