Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/25 Allow external blocks #31

Merged
merged 12 commits into from
Jun 9, 2022
Merged

issue/25 Allow external blocks #31

merged 12 commits into from
Jun 9, 2022

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented May 14, 2022

fixes #25
fixes adaptlearning/adapt_framework#2799

merged #23, #26, #28

External blocks can be added to a branching article. By default, they will be available in their original location but will also be included at the end of the specified branching set.
Note: External blocks added to a branching article will not retain their own _attemptStates history, this is as their history is used to save/restore the branching scenario.

Added

  • _containerId to allow blocks to be assigned to a branching article id

Removed

  • Redundant behaviour, swapping from Adapt.offlineStorage etc to offlineStorage with direct module imports
  • Redundant trackingPosition.js, as these functions are now in core

Requires adaptlearning/adapt-contrib-core#118

@oliverfoster oliverfoster added the enhancement New feature or request label May 14, 2022
@oliverfoster oliverfoster self-assigned this May 14, 2022
@oliverfoster oliverfoster marked this pull request as ready for review May 20, 2022 16:47
oliverfoster and others added 2 commits May 23, 2022 11:42
Co-authored-by: Cahir O'Doherty <41006337+cahirodoherty-learningpool@users.noreply.github.com>
Co-authored-by: Cahir O'Doherty <41006337+cahirodoherty-learningpool@users.noreply.github.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 918bdd9 into master Jun 9, 2022
@oliverfoster oliverfoster deleted the issue/25 branch June 9, 2022 15:01
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow external blocks all core plugins: update to remove references to deprecated functionality
4 participants