Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu item support for responsive image sources #198

Closed
kirsty-hames opened this issue Jul 2, 2024 · 1 comment · Fixed by #200
Closed

Menu item support for responsive image sources #198

kirsty-hames opened this issue Jul 2, 2024 · 1 comment · Fixed by #200
Assignees
@kirsty-hames
Labels
enhancement released

Comments

@kirsty-hames
Copy link
Contributor

Subject of the enhancement

This is one of the feature requests proposed in #122. Being able to define two image srcs split into 'desktop' and 'mobile' to enable differing views and layouts when combined with configurable widths.

Expected behaviour

It would make sense to utilise the jsx image template as per other Adapt plugins. This already handles backwards compatibility for the existing src attribute as well as supporting device screenSize.
@kirsty-hames kirsty-hames self-assigned this Jul 2, 2024
@kirsty-hames kirsty-hames moved this from New to Assigned in adapt_framework: The TODO Board Jul 2, 2024
This was referenced Jul 2, 2024
Open
Merged
@kirsty-hames kirsty-hames moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Jul 2, 2024
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Jul 15, 2024
github-actions bot pushed a commit that referenced this issue Jul 15, 2024
@semantic-release-bot
Chore(release): 7.1.0 [skip ci]
5134f5a 
# [7.1.0](v7.0.2...v7.1.0) (2024-07-15)

### New

* Support for responsive menu item image sources (fixes #198) (#200) ([65ca0c1](65ca0c1)), closes [#198](#198) [#200](#200)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 7.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirsty-hames kirsty-hames

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New: support for responsive menu item image sources (fixes #198) adaptlearning/adapt-contrib-boxMenu
1 participant
@kirsty-hames