Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logger not outputting errors correctly #198

Closed
oliverfoster opened this issue Oct 4, 2023 · 1 comment · Fixed by #199
Closed

Logger not outputting errors correctly #198

oliverfoster opened this issue Oct 4, 2023 · 1 comment · Fixed by #199
Assignees
@oliverfoster
Labels
bug released

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Oct 4, 2023 •
edited
Loading

Subject of the issue

adapt-cli/lib/logger.js

Lines 11 to 16 in c0777a7

warn (...args) {
chalk.yellow(...args)
},
error (...args) {
chalk.red(...args)
},

They never write out to the console, only do the colour wrapping.
@oliverfoster oliverfoster self-assigned this Oct 4, 2023
oliverfoster added a commit that referenced this issue Oct 4, 2023
@oliverfoster
Fix: Logger error and warn output (fixes #198)
99756e2
@oliverfoster oliverfoster mentioned this issue Oct 4, 2023
Merged
@oliverfoster oliverfoster moved this from New to Needs Reviewing in adapt_framework: The TODO Board Oct 4, 2023
joe-allen-89 pushed a commit that referenced this issue Oct 9, 2023
@oliverfoster
Fix: Logger error and warn output (fixes #198) (#199)
cbf473e
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Oct 9, 2023
github-actions bot pushed a commit that referenced this issue Oct 9, 2023
@semantic-release-bot
Chore(release): 3.1.3 [skip ci]
c14df8d 
## [3.1.3](v3.1.2...v3.1.3) (2023-10-09)

### Fix

* Logger error and warn output (fixes #198) (#199) ([cbf473e](cbf473e)), closes [#198](#198) [#199](#199)
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

🎉 This issue has been resolved in version 3.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Logger error and warn output (fixes #198) adaptlearning/adapt-cli
1 participant
@oliverfoster