fix: 3.2.x should satisfied by 3.2.0-beta.1 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for raising this issue and creating a PR with the fix. I'm a little wary this could be a breaking change for some users although it's probably reasonable to consider this as a bugfix. This matches node-semver behaviour and seems to be a more correct interpretation of how |
|
After thinking about this a little more and seeing that #56 also changes caret range behaviour, I think it will make sense to release this in a new major version. As although these PRs could be considered bug fixes they could still require code changes for users relying on the existing behaviour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54