Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved item purchasing system to sell items when inventory is full #99

Merged
merged 2 commits into from
Jun 24, 2023

Conversation

JoshdanG
Copy link
Collaborator

Improves selling when inventory full:

  • larger list of items sold
  • sells one item at a time
  • sells regardless of time or level
  • avoids selling parts of a recipe in progress
  • only sells items in inventory (not stash)
  • considers full with 9 items rather than 8
  • only sells within valid range (450) of fountain

Performance changes (unmeasured):

  • checks only when possible to sell
  • waits one second before re-checking

Removes .mira file that complicated things with limited benefit

Improves selling when inventory full:
* larger list of items sold
* sells one item at a time
* sells regardless of time or level
* avoids selling parts of a recipe in progress
* only sells items in inventory (not stash)
* considers full with 9 items rather than 8
* only sells within valid range (450) of fountain

Performance changes (unmeasured):
* checks only when possible to sell
* waits one second before re-checking

Removes .mira file that complicated things with limited benefit
@JoshdanG
Copy link
Collaborator Author

I wanted to ask if it would be okay to remove the ItemPurchaseSystem.mira file and just work directly with the .lua file. This is much simpler for testing, code tools, etc. and the benefits of .mira seem very minor.

If so, there are some comments that should probably be brought over.

If not, then I will edit the .mira file and compile to .lua.

@adamqqqplay
Copy link
Owner

I wanted to ask if it would be okay to remove the ItemPurchaseSystem.mira file and just work directly with the .lua file. This is much simpler for testing, code tools, etc. and the benefits of .mira seem very minor.

If so, there are some comments that should probably be brought over.

If not, then I will edit the .mira file and compile to .lua.

@JoshdanG Sure, you could remove the mira files. Currently, we are not using mira complier.

Thanks for your work.

@JoshdanG JoshdanG marked this pull request as ready for review June 19, 2023 05:35
Copy link
Owner

@adamqqqplay adamqqqplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@adamqqqplay adamqqqplay changed the title Improve selling when inventory full; remove mira file Improved item purchasing system to sell items when inventory is full Jun 24, 2023
@adamqqqplay adamqqqplay merged commit 2b2691b into adamqqqplay:master Jun 24, 2023
@JoshdanG JoshdanG deleted the improved_full_sell branch June 25, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants