Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around missing RandomFloat() #132

Merged
merged 2 commits into from
Sep 2, 2023
Merged

Work around missing RandomFloat() #132

merged 2 commits into from
Sep 2, 2023

Conversation

JoshdanG
Copy link
Collaborator

@JoshdanG JoshdanG commented Sep 2, 2023

RandomFloat() has randomly floated off -- trying to call it results in the error attempt to call global 'RandomFloat' (a nil value).

Working fix for #131

@JoshdanG JoshdanG linked an issue Sep 2, 2023 that may be closed by this pull request
Heroes not buying items (RandomFloat is missing) #131
Closed
JoshdanG
JoshdanG commented Sep 2, 2023
View reviewed changes
util/AbilityAbstraction.lua Outdated Show resolved Hide resolved
@adamqqqplay adamqqqplay self-requested a review September 2, 2023 13:44
adamqqqplay
adamqqqplay approved these changes Sep 2, 2023
View reviewed changes
Copy link
Owner

@adamqqqplay adamqqqplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, I will release a hotfix version soon.

@adamqqqplay adamqqqplay merged commit 38ccbf7 into adamqqqplay:master Sep 2, 2023
@JoshdanG JoshdanG deleted the randomfloat-fix branch September 3, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamqqqplay adamqqqplay adamqqqplay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Heroes not buying items (RandomFloat is missing)
2 participants
@JoshdanG @adamqqqplay