Improve farming #119

JoshdanG · 2023-07-10T00:59:53Z

Improve Farming Desire Calculation

Check for damage from enemy players instead of any player damage

Fixes issue with (incorrectly) detecting self damage interrupting farming

Removed unhelpful conditions

Check for channeling removed
Check if current action is "idle" removed

Improve Farming Behavior

Fix stacking location

Fixes runtime error

Fix stacking without creeps
Mostly fixes leaving tree-heavy camps uncleared (while still farming)
Fixes leaving baby mud golems behind
Farming now uses 4 states: travelling, near, farming, stacking

Misc Cleanup

Remove commented out and debugging / obsolete code
Add comments
Use more constants
Consolidate conditions required for farming
Move rattletrap specific farming code to separate function
Refactor / tweak camp refresh

Move refresh to before ancient check so it always runs when it should
Simplify 0:30 time check
Change starting value of numCamp and add clarifying comment

New general use functions

Unit.WasRecentlyDamagedByEnemy in MiraDota.lua
utility.GetUnitsTowardsLocationGeneric in utility.lua

1. Remove commented out code 2. Remove debugging code for faceless void 3. Remove obsolete shrine / is T3 destroyed code

Will add again in another commit; this makes the diff more readable

1. Move refresh to before ancient check so it always runs when it should 2. Simplify 0:30 time check 3. Change starting value of numCamp and add clarifying comment 4. Remove unused variables, including "minute"

1. Consolidate conditions required for farming 2. New function Unit.WasRecentlyDamagedByEnemy in MiraDota.lua - Checks if unit was damaged by enemy team - Fixes issue with (incorrectly) detecting self damage interrupting farming 3. Removed unhelpful conditions - check for channeling - check if current action is "idle" 4. Remove setting preferredCamp = nil in GetDesire, this is handled in OnEnd 5. Add comments 6. Use constant BOT_MODE_DESIRE_NONE instead of "0.0"

1. Replace obsolete manual stack points with simple calculation - Fixes running off and tp'ing instead of stacking - Fixes runtime error for camp index > 18 2. Uses new function utility.GetUnitsTowardsLocationGeneric that works on raw locations - Update GetUnitsTowardsLocation to work based on GetUnitsTowardsLocationGeneric

Fixes: 1. Mostly fixes leaving tree-heavy camps uncleared (while still farming) 2. Fixes leaving baby mud golems behind 3. Fixes stacking issues Code Changes: 1. Instead of farmState = 0 or 1, now there are four statuses: - FARM_STATE_TRAVELLING: beyond 800 range, standard move - FARM_STATE_NEAR: Between 800 and 400 range, attack move in case creeps are outside camp - FARM_STATE_FARMING: Attack creeps using FindFarmedTarget - FARM_STATE_STACKING: Run to stack location so camp will stack 2. Moved camp clear/update check earlier so that it's easier to understand 3. Have to be within 200 range of camp to clear because trees often block visibility of creeps even when the camp location is visible - Fixes leaving tree-heavy camps uncleared 4. Checking camp clear now requires #neutralCreeps == 0 - Fixes baby mud golem issue 5. To support #neutralCreeps == 0 check and other edge cases, if camp not clear, but no available target, keep moving toward camp 6. Going into stacking state requires a recent attack - Fixes "stacking" without creeps

JoshdanG · 2023-07-10T01:16:29Z

Reviewing

Be sure to split up commits when reviewing. The first 4 commits are refactoring and especially the rattletrap code move does not diff well.
Hiding whitespace is also helpful for reviewing the GetDesire() changes.

Feature Status

Farming is currently only enabled for Alchemist and Bloodseeker -- the heroes that farming was previously enabled for.
Based on the previously configured desire levels, bots spend most of the time farming. This is probably not optimal, but is an interesting difference from typical bot behavior.
Really doesn't work for ranged heroes
There are plenty of improvements possible - like camp selection and balancing farming with other activities (especially pushing lanes)
The camp clear detection is pretty dumb; it basically runs into each camp to be sure it is clear.

adamqqqplay · 2023-07-10T02:03:45Z

Thank you very much for your continued contribution.
I am a little busy at work recently, and code review will be slower. I'll find time to finish it though, thanks.

ArcherWayne · 2023-07-10T15:30:04Z

Thanks for your contribution. Farming has been a problem for this bot.

I reviewed the code and I think the code are functional and logical. Can you try to test the GPM improvements for these bots?

If the bots can farm as fast as human players do, then they would be more challenging to play against.

JoshdanG · 2023-07-11T03:04:04Z

Thank you very much for your continued contribution. I am a little busy at work recently, and code review will be slower. I'll find time to finish it though, thanks.

No worries. Definitely no urgency from my end.

JoshdanG · 2023-07-11T03:29:24Z

I reviewed the code and I think the code are functional and logical. Can you try to test the GPM improvements for these bots?

If the bots can farm as fast as human players do, then they would be more challenging to play against.

It's definitely not (good) human level, but it's pretty consistently higher than non-farming heroes. Some sample game scoreboards below (Alchemist: 690gpm, Bloodseeker: 632gpm, Bloodseeker: 775 gpm). These games happen to all be wins, but the farming hero generally does not carry the game.

Alchemist

Bloodseeker (bad game)

Bloodseeker (good game)

adamqqqplay · 2023-07-24T02:24:28Z

mode_farm_generic.lua

+	if not (bot:IsAlive()
+			and campUtils.IsStrongJungler(bot)
+			and bot:GetLevel() >=6 and bot:GetLevel() < 30)
+		or IsHumanPlayerInTeam()


Is this condition necessary? I don't quite understand the difference when human players are present.

That logic was already there and I assume working as intended. I'm guessing the intent is that the human player may want to farm, and the bot farming as well could interfere with that. That check can be removed if unwanted; nothing else depends on it.

@JoshdanG Now we only have 2 heroes with farming mode enabled? If so, it is indeed possible to remove this condition, it affects human players less.

adamqqqplay · 2023-07-24T02:27:13Z

util/CampUtility.lua

+--
+-- Currently works by just going a fixed distance away from camp location 
+-- in the bot's current dirction.
+function X.GetCampMoveToStack(bot, camp)


This function is really helpful, thanks!

JoshdanG added 7 commits July 9, 2023 17:43

Tidy mode_farm_generic.lua

452fb96

1. Remove commented out code 2. Remove debugging code for faceless void 3. Remove obsolete shrine / is T3 destroyed code

Remove rattletrap-specific farming

44180c8

Will add again in another commit; this makes the diff more readable

Add rattletrap specific farming code in separate function

26dcb6c

Refactor / tweak camp refresh

a62427b

1. Move refresh to before ancient check so it always runs when it should 2. Simplify 0:30 time check 3. Change starting value of numCamp and add clarifying comment 4. Remove unused variables, including "minute"

adamqqqplay requested review from adamqqqplay and ArcherWayne July 10, 2023 01:57

adamqqqplay reviewed Jul 24, 2023

View reviewed changes

ArcherWayne approved these changes Jul 24, 2023

View reviewed changes

adamqqqplay merged commit 67767a7 into adamqqqplay:master Aug 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve farming #119

Improve farming #119

JoshdanG commented Jul 10, 2023

JoshdanG commented Jul 10, 2023

adamqqqplay commented Jul 10, 2023

ArcherWayne commented Jul 10, 2023

JoshdanG commented Jul 11, 2023

JoshdanG commented Jul 11, 2023

adamqqqplay Jul 24, 2023

JoshdanG Jul 25, 2023

adamqqqplay Jul 25, 2023

adamqqqplay Jul 24, 2023

Improve farming #119

Improve farming #119

Conversation

JoshdanG commented Jul 10, 2023

Improve Farming Desire Calculation

Improve Farming Behavior

Misc Cleanup

JoshdanG commented Jul 10, 2023

Reviewing

Feature Status

adamqqqplay commented Jul 10, 2023

ArcherWayne commented Jul 10, 2023

JoshdanG commented Jul 11, 2023

JoshdanG commented Jul 11, 2023

adamqqqplay Jul 24, 2023

Choose a reason for hiding this comment

JoshdanG Jul 25, 2023

Choose a reason for hiding this comment

adamqqqplay Jul 25, 2023

Choose a reason for hiding this comment

adamqqqplay Jul 24, 2023

Choose a reason for hiding this comment