Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix runtime errors in crystal maiden abilities #114

Merged
merged 2 commits into from
Jul 16, 2023
Merged

Fix runtime errors in crystal maiden abilities #114

merged 2 commits into from
Jul 16, 2023

Conversation

JoshdanG
Copy link
Collaborator

  1. Fix nil arithmetic error for freezingFieldHitSomeoneTime
  • Can prevent all ability usage in rare cases
  1. Fix "Can't call CDOTA_Bot_Script:IsAlive on an object of type [none]" for iceFreezingEnemy
  • Can prevent all ability usage in rare cases
  1. Add comments to crystal maiden abilities
  • Add comments for ability names
  • Add comments for ending freezing field
  1. Remove "else" block that has no body

@JoshdanG
Add comments to crystal maiden abilities; remove non-functional "else"
b595cd7 
1. Add comments for ability names
2. Add comments for ending freezing field
3. Remove "else" block that has no body
@JoshdanG
Fix runtime errors in crystal maiden abilities
e35fa81 
1. Fix nil arithmetic error for freezingFieldHitSomeoneTime
- Can prevent all ability usage in rare cases
2. Fix "Can't call CDOTA_Bot_Script:IsAlive on an object of type [none]" for iceFreezingEnemy
- Can prevent all ability usage in rare cases
adamqqqplay
adamqqqplay approved these changes Jul 16, 2023
View reviewed changes
Copy link
Owner

@adamqqqplay adamqqqplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks!

BTW, modifications about comments may not need to be written in the commit log, because it can be seen from the code.

@adamqqqplay adamqqqplay merged commit aee77d2 into adamqqqplay:master Jul 16, 2023
@JoshdanG JoshdanG deleted the fix_crystal_maiden_errors branch July 23, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamqqqplay adamqqqplay adamqqqplay approved these changes

@ArcherWayne ArcherWayne Awaiting requested review from ArcherWayne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshdanG @adamqqqplay