Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially fix Brewmaster's void spirit / brewling #101

Merged
merged 1 commit into from
Jun 24, 2023

Conversation

JoshdanG
Copy link
Collaborator

Void brewling will now move and attack
Using Astral Pull does not seem to be supported by the Bot API

Also removes old abilities (Corrosive Haze, Drunken Brawler, Thunder Clap) Brewlings no longer gain these abilities from aghs

Illusions go roughly in the direction they decide instead of totally random

Minor reorganization to remove duplicate code

Partially fixes #91

Void brewling will now move and attack
Using Astral Pull does not seem to be supported by the Bot API

Also removes old abilities (Corrosive Haze, Drunken Brawler, Thunder Clap)
Brewlings no longer gain these abilities from aghs

Illusions go roughly in the direction they decide instead of totally random

Minor reorganization to remove duplicate code
Copy link
Owner

@adamqqqplay adamqqqplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!
I have a small suggestion: the commit information could be divided into sections, which can be easily read by other developers.

@adamqqqplay adamqqqplay merged commit e7a0e89 into adamqqqplay:master Jun 24, 2023
@JoshdanG JoshdanG deleted the brewmaster_void_fix branch June 24, 2023 20:23
@JoshdanG
Copy link
Collaborator Author

Thanks for your work!
I have a small suggestion: the commit information could be divided into sections, which can be easily read by other developers.

Will do. Mashing together a combination multiple refactor and then logical changes definitely made this harder to review than necessary.

@adamqqqplay
Copy link
Owner

Thanks for your work!
I have a small suggestion: the commit information could be divided into sections, which can be easily read by other developers.

Will do. Mashing together a combination multiple refactor and then logical changes definitely made this harder to review than necessary.

Thanks for your understanding. But maybe I didn't make it clear before, in addition to submitting multiple separate commits, you could also describe changes in multiple points in one commit. Just like the commit information I modified on the master branch.

The commit style of each project may be different, but they all have something in common. For further understanding, please refer to: https://reflectoring.io/meaningful-commit-messages/

@JoshdanG
Copy link
Collaborator Author

Thanks for your understanding. But maybe I didn't make it clear before, in addition to submitting multiple separate commits, you could also describe changes in multiple points in one commit. Just like the commit information I modified on the master branch.

The commit style of each project may be different, but they all have something in common. For further understanding, please refer to: https://reflectoring.io/meaningful-commit-messages/

I did get a bit confused there. I think I am separating my commit messages into several chunks (separated by empty lines), but I will number them to make that clearer and consistent with the rest of the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brewmaster Void panda not moving (7.33c)
3 participants