Move SCR calls to initWrite() and endWrite() in the openPMD plugin #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Adam,
this PR moves the (currently commented)
SCR_start_outputandSCR_complete_outputcalls to theinitWriteandendWritefunctions in the openPMDWriter.This means that they will be called for every checkpoint which I assume is intended? Note that the
Seriesobject will stay open during the entire simulation, which is necessary e.g. for streaming workflows. So, without this PR both functions would be called exactly once during a simulation.What would happen if these functions are called, but no SCR output is written in-between? This might happen if we write normal (non-checkpoint) output or use any other backend of ADIOS2/openPMD, such as HDF5 or Streaming.
(Note: I'm on holidays for the coming two weeks)