Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: discovered hosts returned as dict #25

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Conversation

adamkirchberger
Copy link
Owner

Update to the Nectl client interface to return a dict of hosts rather than a list which is more efficient for clients to work with.

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for nectl ready!

Name Link
🔨 Latest commit a2fb497
🔍 Latest deploy log https://app.netlify.com/sites/nectl/deploys/653f8f6c9a961c00071e3123
😎 Deploy Preview https://deploy-preview-25--nectl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #25 (a2fb497) into main (1107ac4) will increase coverage by 1.89%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   92.32%   94.21%   +1.89%     
==========================================
  Files          20       20              
  Lines         951      951              
==========================================
+ Hits          878      896      +18     
+ Misses         73       55      -18     
Files Coverage Δ
nectl/configs/cli.py 85.71% <100.00%> (+19.78%) ⬆️
nectl/datatree/cli.py 87.23% <100.00%> (ø)
nectl/datatree/hosts.py 100.00% <100.00%> (ø)
nectl/nectl.py 100.00% <100.00%> (ø)

@adamkirchberger adamkirchberger merged commit 62ef067 into main Oct 30, 2023
12 checks passed
@adamkirchberger adamkirchberger deleted the hosts_return_dict branch October 30, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant