Skip to content

Commit

Permalink
Remove invalid options in example code
Browse files Browse the repository at this point in the history
CLIEngine doesn’t support `extends` and `ecmaFeatures`.
  • Loading branch information
shinnn committed Jul 2, 2016
1 parent 505779d commit 97d8638
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 15 deletions.
16 changes: 3 additions & 13 deletions example/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,7 @@ gulp.task('basic', () => {
gulp.task('inline-config', () => {
return gulp.src('../test/fixtures/**/*.js')
.pipe(eslint({
// gulp-eslint's config works much like .eslintrc with a dash of ESLint's CLI

'extends': 'eslint:recommended',

'ecmaFeatures': {
'modules': true
},

'rules': {
rules: {
'no-alert': 0,
'no-bitwise': 0,
'camelcase': 1,
Expand All @@ -61,11 +53,9 @@ gulp.task('inline-config', () => {
'no-unreachable': 2
},

'globals': {
'$': false
},
globals: ['$'],

'envs': {
envs: {
'node': true
}

Expand Down
2 changes: 1 addition & 1 deletion example/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"globals": {
"$": false
},
"env":{
"env": {
"browser": true,
"node": true
}
Expand Down
1 change: 0 additions & 1 deletion example/format.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ gulp.task('eslint-formatter', () => {
.pipe(eslint.format('compact'));
});


gulp.task('custom-formatter', () => {
function embolden(text) {
return `\u001b[1m${text}\u001b[22m `;
Expand Down

0 comments on commit 97d8638

Please sign in to comment.