Initial implementation of new validation approach #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkerkhove
approved these changes
Feb 10, 2020
src/Promitor.Core.Scraping/Configuration/Serialization/ConfigurationSerializer.cs
Show resolved
Hide resolved
src/Promitor.Core.Scraping/Configuration/Serialization/IErrorReporter.cs
Show resolved
Hide resolved
src/Promitor.Core.Scraping/Configuration/Serialization/v1/Core/AzureMetadataDeserializer.cs
Outdated
Show resolved
Hide resolved
...itor.Core.Scraping/Configuration/Serialization/v1/Providers/ContainerRegistryDeserializer.cs
Show resolved
Hide resolved
src/Promitor.Core.Scraping/Configuration/Serialization/v1/Core/MetricAggregationDeserializer.cs
Show resolved
Hide resolved
src/Promitor.Core.Scraping/Configuration/Serialization/v1/Core/AggregationDeserializer.cs
Show resolved
Hide resolved
| // TODO: Check for invalid formats (crontab expression, timespan, etc) | ||
| // TODO: Add a test to make sure that the error is against the mapping node rather than its value for missing required fields | ||
|
|
||
| private class TestConfigObject |
There was a problem hiding this comment.
Same about those, dedicated files for final PR
|
|
||
| // TODO: Test for duplicate field registration | ||
|
|
||
| private class RegistrationConfig |
There was a problem hiding this comment.
Same here, dedicated files for final PR
I've altered the way that the deserializers work and are defined so that they are simpler to create, but also so that we can record validation failures during the deserialization process. This allows us to provide much better validation messages than we can if we take the approach of validating based on the deserialized objects. In this initial change I haven't gone ahead and updated all of the deserializers because I wanted the change to be kept small. I've also not actually hooked up the validation messages in any way - instead I've just provided a stub ErrorReporter object that doesn't actually do anything yet.
adamconnelly
force-pushed
the
validation-stage-1
branch
from
b2461bc
to
4b3f3f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've altered the way that the deserializers work and are defined so that they are simpler to create, but also so that we can record validation failures during the deserialization process. This allows us to provide much better validation messages than we can if we take the approach of validating based on the deserialized objects.
In this initial change I haven't gone ahead and updated all of the deserializers because I wanted the change to be kept small. I've also not actually hooked up the validation messages in any way - instead I've just provided a stub ErrorReporter object that doesn't actually do anything yet.
Fixes #