avoid boxing in RGB Equals

adamabdelhamed · Dec 31, 2024 · 1b51b2b · 1b51b2b
1 parent 59c0b03
commit 1b51b2b
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/PowerArgs/HelperTypesPublic/RGB.cs b/PowerArgs/HelperTypesPublic/RGB.cs
@@ -4,7 +4,7 @@
 
 namespace PowerArgs;
 [ArgReviverType]
-public readonly struct RGB
+public readonly struct RGB : IEquatable<RGB>
 {
     public static readonly float MaxDistance = (float)Math.Sqrt((255 * 255) + (255 * 255) + (255 * 255));
 
@@ -98,12 +98,11 @@ public RGB(byte r, byte g, byte b)
         this.B = b;
     }
 
+    public bool Equals(RGB other) => this.R == other.R && this.G == other.G && this.B == other.B;
+
     public override bool Equals(object obj)
     {
-        if (obj is RGB == false) return false;
-        var other = (RGB)obj;
-        if (other == null) return false;
-        return this.R == other.R && this.G == other.G && this.B == other.B;
+        return obj is RGB rgb && Equals(rgb);
     }
 
     public bool EqualsIn(in RGB obj)