Update keychron.service #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `RemainAfterExit` and changed `Type` to simple instead of oneshot
adam-savard
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought maybe it can be improved if you use a laptop. Just let it start automatically but if you need to disconnect the keychron because you're going to use the integrated keyboard (travel, conmuting...) then it would be nice to simply do
systemctl stop keychronand restore the config.The settings changed in the service file:
Type=simple(the default setting) is used when the process configured withExecStartis the main process of the service. Such units will wait until the process specified byExecStartreturns, then deactivate by running the process specified by ExecStop.With
RemainAfterExit=yes, the service will be considered active even when all its processes have returned, and therefore the process specified byExecStopwill not run automatically. However, this setting is not recommended for real services since the service will still appear as being active even if it has crashed, but it is useful for our use case.