Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converted to chrome.extension.onMessage [Fixes #145] #151

Closed
wants to merge 2 commits into from
Closed

converted to chrome.extension.onMessage [Fixes #145] #151

wants to merge 2 commits into from

Conversation

engstrom
Copy link
Contributor

@engstrom engstrom commented Jan 9, 2014

No description provided.

@adam-p
Copy link
Owner

adam-p commented Jan 11, 2014

Thanks for the submission. This is the second-ever pull request to Markdown Here!

But... I think there's a bit more to do before merging it:

Part of changing chrome.runtime.onMessage to chrome.extension.onMessage is also changing chrome.runtime.sendMessage in the same way. So there are a couple more lines that need to be updated.

Have you tested with Chromium <= 25? We're going to need to verify that the fix actually works.

@engstrom
Copy link
Contributor Author

Changes are tested and working on Version 25.0.1323.1 (167142).

adam-p added a commit that referenced this pull request Jan 12, 2014
@adam-p
Copy link
Owner

adam-p commented Jan 12, 2014

I also tested on Version 24.0.1291.0 (160933) and the fix seems good.

I have merged this into the development branch. This will get merged into master when I prep the next release, which should be pretty soon. (This PR would get closed automatically at that time anyway, but I'm going to close it manually now.)

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants