Support Thunderbird 68 #577
Comments
|
Hi there! Thanks |
|
I don't know much (read: nothing) about add-ons development, but I really need this one to work on tb 68. I hacked the sources a bit and managed to install it. I don't know if it's good enough or not, but might be a start for whomever wants to take it further: I roughly followed this guide: https://developer.thunderbird.net/add-ons/updates |
|
This seems to be a duplicate of #536 |
Is it, though? That issue talks about Thunderbird version 64. |
|
This is probably a dead project by now .. a pity. |
Thunderbird 64 was the beta, which is now what Thunderbird 68 became. So anything after Thunderbird 60.x wasn't going to work with this, including Thunderbird 69 which is the next version.
Does this addon actually use XUL in any way? we should check the source. It may require a fork as it seems that @adam-p isn't responding, he didn't respond to the email I sent him either clarifying whether or not he was still maintaining this. Though I do see he is still active based on his github contributions so who knows what is going on.
Yeah, and there is no alternative to Header Tools Lite that I know of either. It was when you want to reply to a mailing list, thread that you do not have in your email. You could edit the |
|
@yhager (and perhaps everyone else too): Thanks for that kick-start up there. 😸 Spent a little bit of time crash learning WebExtensions (still fresh). With your patch, #459, and along with the remainder of the build instructions enabled (clever build system btw) i.e. diff --git a/src/manifest.json b/src/manifest.json
index f3c5af4..4d1fae5 100644
--- a/src/manifest.json
+++ b/src/manifest.json
@@ -12,7 +12,7 @@
"128": "common/images/icon128.png",
"512": "common/images/icon512.png"
},
- "permissions": ["contextMenus", "storage"],
+ "permissions": ["menus", "storage"],
"background": {"page": "chrome/background.html"},
"content_scripts": [
{
@@ -46,7 +46,15 @@
,"applications": {
"gecko": {
- "id": "markdown-here-webext@adam.pritchard"
+ "id": "markdown-here-webext@adam.pritchard",
+ "strict_min_version": "68.0"
+ }
+ }
+ ,"legacy": {
+ "type": "xul",
+ "options": {
+ "page": "common/options.html",
+ "open_in_tab": true
}
}
}
diff --git a/utils/build.js b/utils/build.js
index 9274aab..7a32bf1 100644
--- a/utils/build.js
+++ b/utils/build.js
@@ -9,7 +9,7 @@
var fs = require('fs');
var file = require('file');
var archiver = require('archiver');
-var MetaScript = require('MetaScript');
+var MetaScript = require('metascript');
var BASE_DIR = '..';
@@ -22,7 +22,7 @@ var THUNDERBIRD_EXTENSION = file.path.join(DIST_DIR, 'thunderbird.xpi');
var CHROME_INPUT = [/^manifest\.json$/, /^common(\\|\/)/, /^chrome(\\|\/)/, /^_locales(\\|\/)/];
var FIREFOX_INPUT = CHROME_INPUT;
-var THUNDERBIRD_INPUT = [/^chrome.manifest$/, /^install.rdf$/, /^common(\\|\/)/, /^firefox(\\|\/)/];
+var THUNDERBIRD_INPUT = [/^manifest\.json$/, /^chrome.manifest$/, /^install.rdf$/, /^common(\\|\/)/, /^firefox(\\|\/)/, /^_locales(\\|\/)/];
var CHROME_PLATFORM = 'chrome';
var FIREFOX_PLATFORM = 'firefox';This is the bare minimum I think to get it at least working "out of the box". I never used the Options of this extension so I have no idea what was working versus what wasn't/isn't. I might spend a little more time on a diff patch that can be applied with Refs:
|
|
P.S. Don't forget to do: $ cd utils
$ npm install
$ cd ..... before building since the routine currently utilizes node.
See adam-p/markdown-here/blob/ |
|
Noticed a glitch with the manifest.json. Needs: diff --git a/src/manifest.json b/src/manifest.json
index 4d1fae5..e496210 100644
--- a/src/manifest.json
+++ b/src/manifest.json
@@ -50,11 +50,5 @@
"strict_min_version": "68.0"
}
}
- ,"legacy": {
- "type": "xul",
- "options": {
- "page": "common/options.html",
- "open_in_tab": true
- }
- }
+ ,"legacy": true
}... which seems to correct it so there aren't two entries in the menu (Tools -> Add-on Preferences)... one being "dead". The remaining options dialog menu entry still opens and opens in a new tab here. The duplication is possibly from the install.rdf Doesn't appear to save (or retrieve which seems to be why the alert box shows up) preferences (Options) either. More work todo perhaps. Again I only utilize the basic functions of this AO so haven't twiddled beyond that. |
|
Kudos to @Martii for the patch. |
|
@Martii , thanks for the patch, it works like a charm (at least for the functionalities I use...)
I agree with @dngray , this is too good a project to die like this, it should be forked. Still, @adam-p should have a say in it. Let's hope he gets back in touch... @EBoisseauSierra (and/or anyone who's interested), here's the procedure I followed to make it work:
Cheers! |
|
@light-wizard Thank you for the detailed instructions. I have this extension working again in thunderbird 68.0. |
|
Sure wish https://developer.mozilla.org/docs/Mozilla/Add-ons/WebExtensions/manifest.json/permissions had better explanations of the permissions. Chromium/Chromes references at https://developer.chrome.com/apps/declare_permissions seems to be filled in a bit more. The reason why I say this... is the change of permissions doesn't seem to be even needed for TB, in legacy mode, but does need to be there for, at least, Chromium/Chrome. So the: - "permissions": ["contextMenus", "storage"],
+ "permissions": ["menus", "storage"],... probably breaks building the extension .zip for the other applicable browsers because On another brief tangent...
Oh dear. There goes several clients web cam apps. :\ This explains why it took forever to find one Chrome App for a specific cam series I think. It wasn't searchable in the Chrome Web Store but referenced in the cam software. Blehh. |
|
Hmmm... converting the preferences (Options) store to a WebExtension seems to have hit a wall/hiccup (mine or TB's IDK atm). In simple, resultant, English that means it breaks using markdown for sending a message completely. I think I see why dev is stalled here. I need some rest and perhaps look at this fresh after a wee break. |
|
Composed a rather complex markdown message in TB 68.1.x and it failed to send with |
|
Could the .xpi be posted here please? I am not sure I can follow these instructions. If some users have already built a version compatible with TB 68 it would really be useful to be able to have the .xpi install file. |
|
@gbstan I have uploaded my build here. Comes with absolutely no warranty of any kind. You can use it if you decide that you trust me, a perfectly random stranger on the internet. See how I got you to hesitate? That's why no one had posted a build before. It is actually quite buggy, but if you really need to use it, it kind of sort of works. I think the whole extension needs a lot of work to be usable on an everyday basis. |
|
Thank you! It seems to work for my use cases! Great
…On 09/10/2019 14:54, Francisco Pina-Martins wrote:
@gbstan <https://github.com/gbstan> I have uploaded my build here.
Comes with absolutely no warranty of any kind. You can use it if you
decide that you trust me, a perfectly random stranger on the internet.
markdown_here.tar.gz
<https://github.com/adam-p/markdown-here/files/3707544/markdown_here.tar.gz>
See how I got you to hesitate? That's why no one had posted a build
before. It is actually quite buggy, but if you *really* need to use
it, it kind of sort of works.
I think the whole extension needs a lot of work to be usable on an
everyday basis.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#577?email_source=notifications&email_token=AA6LGR7NSHQU75XQE6G35D3QNXPBTA5CNFSM4IUWP2VKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAX6YFY#issuecomment-540011543>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA6LGR4CZFJGRPE36DYNVULQNXPBTANCNFSM4IUWP2VA>.
|
Thank you ! Your build is very convenient and I think you are credible |
|
I have moved on from this and found a better solution using pandoc. I haven't been happy with Thunderbird for some time for these reasons:
For new users I suggest mutt-wizard. Also I am keeping an eye on Aerc and Meli. I very rarely send emails in markdown or HTML as it is rarely needed. This secret sauce looks to be just the thing I need on the occasion I do need to. |
|
With Manjaro AND Ubuntu 18.04 I get this ERROR: when closing Thunderbird |
|
Thanks for the Th 68 tuto, happy to see markdown back. |
|
The build shared by @StuntsPT above doesn't seem to work at all on Thunderbird 68.2.2 unfortunately. A workaround for the meantime is to run Markdown text through something like Remarkable and just copy-paste the result into Thunderbird. Obviously this is not as convenient as markdown-here, but at least it produces a more-or-less usable result. |
|
I have been using Mutt Secret Sauce now for a while. It makes fairly nice emails, and also sends a plain-text part using multipart/alternative. The template can be fully customized to your needs. It uses Pandoc which is likely to be maintained well into the future. You can actually use any markup language you like, not just Markdown, but AsciiDoc or whatever else you fancy. One of the features I really like about it, is the rendering with MIMEmbellish occurs when you send the email, which means the markdown copy gets saved in your outbox. This really handy if you need to reply to it, and make corrections as you get to keep the email in markdown format. If you can handle the learning curve of using Mutt, it's an awesome option. That said the mutt-wizard makes that a fair bit easier. |
Thanks a lot ! For now, it's working like a charm ! |
|
Maybe somebody should open a WIP Pull request so we can all report issues/make fixes/suggestions toward it. |
|
There's an insane number of forks of this repo (7.6K)! However, most of them are way behind the upstream repo. I've added my own fork and created a release using the patches from this issue. The binary build in the release is identical to the one posted by StuntsPT except that it has the additional patch from Martii added. You can verify this by unpacking both The preferences dialog still doesn't work properly, although checking the box for TeX math support did work for me. Unfortunately, I'm not knowledgeable and motivated enough to fix the preferences dialog myself, but I'd welcome PRs from anyone who wants to work in this area. |
|
I don't know what it would take to get a new binary uploaded to the add-ons store. If anyone has thoughts about that, please let me know. |
It most likely won't. It will also break again with Thunderbird 78 without further development as a lot of that XUL stuff is being removed completely meaning that updating the manifest isn't going to be enough. Someone will need to make a hard fork, check out code, and make changes. Uploading an tarball here is not sufficient. The code will have to go through the review process: |
That does not mean there is active development. Many click the fork button instead of the star. You can get a more accurate view of what the forks actually have done https://github.com/adam-p/markdown-here/network (which is basically nothing), scroll along to the end of the adam-p base repo. |
|
The network view wasn't showing yesterday. It said there were too many forks and it just listed them. However, presumably due to my creating a new fork with commits in it, the network view is showing again. The great majority of recent commits in the network are bots, either fixing dependencies or optimizing images. There are also a lot that appear to be plain mistakes (people adding stuff to the wrong repo) and others making changes that are useful only to the committer. I didn't see anything useful that isn't already in a PR to the upstream repo. |
|
Hi to all, just to let you know I am very interested in this plugin too! Regards, |
Thank you very much. It works with e-mails. |
I went into same problems after upgrading to Thunderbird 68.7.0. |
|
I was using a version I'd patched and built for a while, however my package manager finally updated to Thunderbird 78.3.1. This means the add-on will no longer work. It will be a moderate development job to get it updated, and I don't know enough JS, let alone add-on development to update it. Anyone that's looking for a less-than-ideal solution could try what I'm doing for now: Using pandoc, convert your email in markdown to HTML: Then copy the raw HTML, and in your Thunderbird compose window select As well as being more time consuming, pandoc also has different the behaviour. E.g. I use a lot of |
|
Has anyone started an effort to get the extension migrated to MailExtensions? I wonder if some interested folks could get organized in a chat room, see what has been done, avoid duplicating effort, and use everyone's strengths and limited free time to revive the project? |
|
@neilmayhew Thank you for reaching out. I'll close this issue, and eagerly look forward to progress in #644. 🙂 |
and others
After updating to Thunderbird 68, the add-on has become disabled.
I would be very happy if it could be updated to work with this new version 🙂 .
The text was updated successfully, but these errors were encountered: