Fix a bug where errors could leak on extremely large stream chunks

[haggholm]

I don't expect a lot of people are going to see this, but we have encountered an issue where an error is thrown as an unhandled exception:

Cannot create a string longer than 0x1fffffe8 characters

This happens here:

    stringifier.on('end', function(){
      callback(undefined, chunks.join(''));
    });

Obviously, if chunks.join() throws an error, it is leaked rather than passed to the callback. I suppose you don't normally expect chunks.join() to fail, but it is in fact posssible.

I'm not sure what style you prefer for this sort of thing; this ought to work and be proof to double-invoking callbacks, but feel free to edit as needed or desired, obviously.

[wdavidw]

Thank you for reporting and preparing a fix, we will need a test case to reproduce the issue, do you think you could prepare one ?

[haggholm]

Maybe you can adapt something from something along these lines? Throws an unhandled exception before my fix, returns it to the callback with it. Of course it's kind of annoying because it's takes up a bunch of CPU and memory, but, well, it only happens with huge strings.

const {stringify} = require("csv-stringify");
const {randomBytes} = require("crypto");

stringify(Array.from({length: 200_000}).map(
	() => Array.from({length: 100}).map(
		() => "ABCDEFGHIJKLMNOPQRSTUVXYZ0123456789")), (err, res) => {
	if (err) {
		console.error("Failed with error:", err);
	} else {
		console.info("Content length:", res.length);
	}
});

[wdavidw]

Thank you!