Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 bugs fixed. Only tested on samd51 #129

Merged
merged 1 commit into from
Jul 5, 2020
Merged

Conversation

slyalfa
Copy link

@slyalfa slyalfa commented Jul 5, 2020

1: Fix for baud samd21 vs samd51
2: Added fix for first run where super slow first run of crc would cause
overruns on USART.
3: Prevent GCC from optimizing out a busy wait loop in Xmodem code

1: Fix for baud samd21 vs samd51
2: Added fix for first run where super slow first run of crc would cause
overruns on USART.
3: Prevent GCC from optimizing out a busy wait loop in Xmodem code
Copy link

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine! We never use the UART bootloader, but these changes should not affect the non-UART part, and they look perfectly reasonable.

@dhalbert dhalbert merged commit 85dcfde into adafruit:master Jul 5, 2020
@leomar95
Copy link

leomar95 commented Aug 5, 2020

Hi @slyalfa. I'm trying to upload the Metro-M4 bord with us using BOSSA. Sometimes it worked. I think that art communication enters a timeout.

Did you have tried to update via bossa?

@slyalfa
Copy link
Author

slyalfa commented Aug 6, 2020 via email

@leomar95
Copy link

I was programming my board with PL2303(usb-serial). That was the problem. I tested without a converter and everything worked.

Thanks for your help @slyalfa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants