Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vectorio rotation issue #9851

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Conversation

FoamyGuy
Copy link
Collaborator

@FoamyGuy FoamyGuy commented Dec 2, 2024

Resolves: #8742

When the mirrored axis are applied we need to subtract one so that pixel index 0 becomes index 319 on a display that has width of 320px without this we attempt to use index 320 which is out of the display bounds and ignored.

Testing on a pyportal with the tft reproducer from the issue now correctly shows the green outline around all 4 sides of the display in all 4 rotations.

@FoamyGuy
Copy link
Collaborator Author

FoamyGuy commented Dec 2, 2024

This was a relatively small change, but it still overflowed a few of the tightest builds. I thought I could shave a little bit of space by removing a duplicated debug message, but that doesn't save anything because of the way they're set to void by default anyhow.

I opted to disable vectorio for the two m4 express boards without built-in displays and disabled flopyio for the openbook_m4, the others had already disabled it and this one has a built-in eink display so vectorio is a bit more practical to use on the hardware. I'm open to other suggestions for getting it to fit.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Good work debugging this!

@tannewt tannewt merged commit 0c9aa80 into adafruit:main Dec 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent rendering of border pixels with vectorio
2 participants