Espressif: I2C timeouts calculated based on tick rate. #9538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
requested changes
Aug 20, 2024
There was a problem hiding this comment.
In V5.3, i2c_master_write_to_device() is deprecated and replaced with i2c_master_transmit(), which takes the timout in ms. I think it would be good to upgrade to that.
We changed CONFIG_FREERTOS_HZ from 100 to 1000 for most boards in #9134. So the old timeout was 100 10ms ticks = 1 second, not 100ms, which is what it is with the new CONFIG_FREERTOS_HZ . That may be the problem in #9535. Your change in this PR keeps it at 100 ticks (100 ms).
tedder
added a commit
to tedder/tedder-metar-map
that referenced
this pull request
Aug 20, 2024
might just be a workaround, and this might fix it: - adafruit/circuitpython#9538 see threads: - https://forums.adafruit.com/viewtopic.php?t=208556 - https://forums.adafruit.com/viewtopic.php?t=207715 - adafruit/circuitpython#4669 - adafruit/circuitpython#9535
|
Closing this, as we'll eventually switch to the new adc api. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
100 * tick rate / 1000
Does not affect or fix #9535 unfortunately.