Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up from this: adafruit/Adafruit_CircuitPython_EMC2101#34 Upgrading my name 😉 and otherwise updating the mailmap file.
I have updated the mailmap file in here too. I split my changes into two commits: One is just my own name correction and other changes that I also submitted to the EMC2101 library, the other is my best attempt at cleaning up the output of
git shortlog -s -e
andgit shortlog -s -e -n
, without making too many assumptions. That does mean there are duplicates in the shortlog still, because I didn't know which email of multiple valid-looking ones to use.I did notice a handful of additional "name upgrades", I used
git log --author="whatever"
and sometimes github accounts to verify I was putting the most recent one in the mailmap, hopefully I got everything right.(I swear I could spend hours every week updating mailmap files and still not get them all... So I will happily help my siblings when they've committed under both dead and upgraded names on a repo I am already messing with, if the assistance is not unwelcome.)
Feel free to edit, drop the last commit, reject everything except my own name correction, etc.
Here is the diff in
git shortlog -s -e
for the first commit, probably the easiest way to review it:authors-1.diff.txt
Here is the diff in
git shortlog -s -e
for the second commit:authors.diff.txt
I did not attempt to search the contents of files to update names, since my old name wasn't in any files, just the commit log. Future work I guess.