espressif: add user-specified socket connect() timeout #9210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In espressif, adds user-specified socket
connect()
timeout by doingconnect()
on the non-blocking socket, and then polling withselect()
for success.RP2040 CYW43 already has similar code (though it doesn't check for ctrl-C or do background tasks)
Tested with
adafruit_requests
. IMPORTANT:adafruit_requests
tries to connect twice, which can make the timeout appear to be twice as long. This is an issue withadafruit_requests
, not with this fix. I will bring this up as an issue in that library.Tagging @SanJoseBart and @bitmitt who were in the #8266 discussion.