esp-idf-config/sdkconfig.defaults: Fix TLS access to api.github.com; remove BLE from 4MB ESP32-S3 #8924
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of the options below were not set (and therefore not turned on), and it caused TLS access to
api.github.com
to not work at all.Turning on either one fixes the problem. Turning on
CONFIG_MBEDTLS_ECP_NIST_OPTIM
instead ofCONFIG_MBEDTLS_ECP_FIXED_POINT_OPTIM
is smaller (+2.2kB vs +6.9kB) and faster (1.6 seconds vs 7.6 seconds, at least some of the time).I don't understand why some "OPTIM" must be turned on for it to work at all, but I'll accept that at face value. I experimented with various combinations.
tag @justmobilize
EDIT: This didn't fit on a few boards, so I went ahead and did the refactoring and BLE trimming we talked about:
_bleio
by default on ESP32-S3 4MB boards._bleio
by default inmpconfigport.mk
for C3 and C6, and then removed that setting from a bunch ofmpconfigboard.mk
files.gifio
andjpegio
on any boards withdisplayio
enabled (consulted with @jepler about this). Previous those modules were dependent onespcamera
, which may just have been copy pasta or something like that.