displayio: add, check "readonly" flag for groups #8923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Feb 15, 2024
|
I think some stuff about declaring the splash screen can be simplified but I didn't want to add it to this PR: https://github.com/jepler/circuitpython/compare/groups-in-rom...jepler:circuitpython:splash-readonly-memory?expand=1 |
jepler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing performed on pycamera / memento
However, for some reason serial output wasn't echoing back to the computer(!) during my test, I could only read it on the LCD(!). I can't guess why this could be related to this PR but maybe it is; I haven't seen it before now and it's a weird failure to go unnoticed for any length of time. [reproduced with c84c066 but not on a different computer, so I'll chalk it up to "laptop needs to be rebooted and is acting out"]
closes: #8873