Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old pcnt, rmt and timer group drivers #8909

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Feb 13, 2024

The new ones handle resource tracking for us. They also do a better job running when the flash cache is disabled, which is the source of bugs when interacting with flash over USB.

Fixes #6998 and fixes #8379

The new ones handle resource tracking for us. They also do a
better job running when the flash cache is disabled, which is the
source of bugs when interacting with flash over USB.

Fixes micropython#6998 and fixes micropython#8379
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I tested rotaryio on an ESP32-S3 but not anything else.

@dhalbert dhalbert merged commit 49d952c into adafruit:main Feb 13, 2024
136 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pulseio deinit() not cleaning up properly on ESP32-S2/S3 Espressif: FrequencyIn causes crashes
2 participants