Reject RLE-compressed BMP files #8735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have to get 36 bytes back in metro m0 pinyin: |
|
Some errors that were paraphrases of each other were consolidated to a single message. Some qstr refactoring was also done, though this sometimes produces little or no size improvement. |
jepler
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7450. Fixes #8374.
OnDiskBitmapdid not check for compression values 1 and 2, which indicate RLE compression.Tested with files from #8374 on a Matrix Portal S3.
NYJ.bmpthrows the new exception, as expected: it is RLE-compressed.NYJ1.bmpis not compressed and works.