Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8631.
Seems to fix ESP32-S3 BLE acting as a simple central. See https://forums.adafruit.com/viewtopic.php?t=206024 for user problems. I will point the users in that thread to the artifacts once this has built.
Tested on a BerryMed Pulse Oximeter with the library's simpletest.
Notes:
BLE_ERR_SUCCESS
is 0, but was being used in places where the return values are actuallyBLE_HS_*
. Nimble has multiple sets of error return codes, but no corresponding types, so it's hard to figure out which codes to use where.BLE_HS_*
values don't have a zeroBLE_HS_OK
orBLE_HS_SUCCESS
, unfortunately.common_hal_bleio_characteristic_set_value()
was being used to set a remote Characteristic value during discovery, but this did not work.bufinfo
, but was not.There may be other problems, and the functionality is still limited in several ways. But this seems to fix some basic issues that were holding up using ESP32-S3 BLE as a central.