Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge 8.2.x to main #8575

Merged
merged 2 commits into from
Nov 11, 2023
Merged

merge 8.2.x to main #8575

merged 2 commits into from
Nov 11, 2023

Conversation

dhalbert
Copy link
Collaborator

@UnexpectedMaker could you look over the revised files for your boards? Thanks.

@dhalbert dhalbert requested a review from tannewt November 10, 2023 01:01
@dhalbert dhalbert mentioned this pull request Nov 10, 2023
Merged
tannewt
tannewt requested changes Nov 10, 2023
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want the flash to be qio as well.

ports/espressif/boards/unexpectedmaker_bling/mpconfigboard.mk Outdated Show resolved Hide resolved
ports/espressif/boards/unexpectedmaker_tinywatch_s3/mpconfigboard.mk Outdated Show resolved Hide resolved
@dhalbert @tannewt
UM boards are qio
b1b01e2 
Co-authored-by: Scott Shawcroft <scott@tannewt.org>
@dhalbert dhalbert requested a review from tannewt November 10, 2023 23:10
tannewt
tannewt approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dhalbert dhalbert merged commit 75fcacd into adafruit:main Nov 11, 2023
@dhalbert dhalbert deleted the 8.2.x-to-main-2023-11-09 branch November 11, 2023 01:42
@UnexpectedMaker
Copy link

Thanks @dhalbert !

@dhalbert dhalbert mentioned this pull request Nov 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhalbert @UnexpectedMaker @tannewt