Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ESP32S3 camera to rev D #8528

Merged
merged 5 commits into from
Oct 30, 2023
Merged

update ESP32S3 camera to rev D #8528

merged 5 commits into from
Oct 30, 2023

Conversation

ladyada
Copy link
Member

@ladyada ladyada commented Oct 27, 2023

Hardware pin changes

jepler
jepler previously approved these changes Oct 27, 2023
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge if green :)

@jepler
Copy link
Member

jepler commented Oct 27, 2023

boards/adafruit_esp32s3_camera/board.c:90:9: error: passing argument 19 of 'common_hal_busdisplay_busdisplay_construct' makes pointer from integer without a cast [-Werror=int-conversion]
   90 |         45,  // backlight pin
      |         ^~
      |         |
      |         int
In file included from ../../shared-module/displayio/__init__.h:28,
                 from boards/adafruit_esp32s3_camera/board.c:33:
../../shared-bindings/busdisplay/BusDisplay.h:44:78: note: expected 'const mcu_pin_obj_t *' but argument is of type 'int'
   44 |     uint8_t *init_sequence, uint16_t init_sequence_len, const mcu_pin_obj_t *backlight_pin, uint16_t brightness_command,
      |                                                         ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~

the argument needs to be something like &pin_GPIO45, not just the number.

@dhalbert dhalbert changed the title update to rev D update ESP32S3 camera to rev D Oct 27, 2023
@tannewt
Copy link
Member

tannewt commented Oct 27, 2023

I think the branch needs the newer changes from adafruit/main merged in to fix the build.

@jepler
Copy link
Member

jepler commented Oct 28, 2023

I merged main to this PR branch

jepler
jepler previously approved these changes Oct 28, 2023
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now is green! mark out of draft when ready

@ladyada
Copy link
Member Author

ladyada commented Oct 28, 2023

thanks! i was about to sit down and figure this out and its done for me <3 it :)

@tannewt tannewt marked this pull request as ready for review October 30, 2023 17:40
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tannewt tannewt merged commit 05e6db9 into adafruit:main Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants