Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass subobject into native subscr #8522

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Pass subobject into native subscr #8522

merged 1 commit into from
Oct 25, 2023

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Oct 25, 2023

This allows PixelBuf to call transmit after setting a value.

Fixes #8488

@tannewt
Pass subobject into native subscr
be30c12 
This allows PixelBuf to call transmit after setting a value.

Fixes micropython#8488
@tannewt tannewt requested a review from dhalbert October 25, 2023 18:45
dhalbert
dhalbert approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tannewt tannewt merged commit 1328299 into adafruit:main Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ref #4682 - Pixelbuf has no attribute _transmit -- problem seems to be back
2 participants
@tannewt @dhalbert