DotClock Touch Screen pin fixes/additions #8491
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes a few of the Hacktablet and Makerfabs pin names for consistency. I also believe the RGB pins were defined backwards on the Makerfabs board. I actually have the 1024x600 board but from everything I have seen online they should be connected the same way as the 800x480 board. Before this change, the following code drew a black line rather than a green line, reversing the order of the RGB pins resolved it.
Removing the screen dimensions from the TIMINGS table pointer allows generic initialization code to work across boards/displays. The display dimensions are included within the table so I don't think having it as part of the name is necessary. That being said, I know generally Adafruit prefers to make separate board definitions for similar boards with different configurations (flash size, psram, etc) but building the Makerfabs board with both a TFT_TIMINGS_800x480 and a TFT_TIMINGS_1024x600 table might allow a single board firmware to be used on both board types as I believe everything else is identical.
Let me know if a single board definition for the two display dimensions on the Makerfabs board is desirable and I'll update the PR accordingly.
I sent a couple e-mail messages to Makerfabs asking about VID/PID codes for both board variants as it looks like the numbers currently being used belong to Adafruit. I don't know if that was the correct route to take or if I'll ever hear back from Makerfabs. If I do hear back, I'll go ahead and create another PR to add the 1024x600 variant of the board.
EDIT: Makerfabs responded saying they would forward the VID/PID when they received them from Espressif.