Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DotClock Touch Screen pin fixes/additions #8491

Merged
merged 6 commits into from
Oct 23, 2023
Merged

Conversation

RetiredWizard
Copy link

@RetiredWizard RetiredWizard commented Oct 20, 2023

This changes a few of the Hacktablet and Makerfabs pin names for consistency. I also believe the RGB pins were defined backwards on the Makerfabs board. I actually have the 1024x600 board but from everything I have seen online they should be connected the same way as the 800x480 board. Before this change, the following code drew a black line rather than a green line, reversing the order of the RGB pins resolved it.

import board
from adafruit_turtle import Color, turtle
import framebufferio
import dotclockframebuffer
import displayio
displayio.release_displays()
fb=dotclockframebuffer.DotClockFramebuffer(**board.TFT_PINS,**board.TFT_TIMINGS_800x480)
display = framebufferio.FramebufferDisplay(fb)
turtle = turtle(display)
turtle.pendown()
turtle.pencolor(Color.GREEN)
turtle.forward(100)

Removing the screen dimensions from the TIMINGS table pointer allows generic initialization code to work across boards/displays. The display dimensions are included within the table so I don't think having it as part of the name is necessary. That being said, I know generally Adafruit prefers to make separate board definitions for similar boards with different configurations (flash size, psram, etc) but building the Makerfabs board with both a TFT_TIMINGS_800x480 and a TFT_TIMINGS_1024x600 table might allow a single board firmware to be used on both board types as I believe everything else is identical.

Let me know if a single board definition for the two display dimensions on the Makerfabs board is desirable and I'll update the PR accordingly.

I sent a couple e-mail messages to Makerfabs asking about VID/PID codes for both board variants as it looks like the numbers currently being used belong to Adafruit. I don't know if that was the correct route to take or if I'll ever hear back from Makerfabs. If I do hear back, I'll go ahead and create another PR to add the 1024x600 variant of the board.

EDIT: Makerfabs responded saying they would forward the VID/PID when they received them from Espressif.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@tannewt tannewt merged commit 1430cc6 into adafruit:main Oct 23, 2023
@RetiredWizard RetiredWizard deleted the v9debug branch October 24, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants