Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build directories assumed by S3 upload commands #8483

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

dhalbert
Copy link
Collaborator

The mpy-cross build directories changed but the paths used to upload to S3 were not quite right in some cases.

Unfortunately this has to be merged to confirm that the upload paths are correct.

Fixes errors seen from v1.20 merge here: https://github.com/adafruit/circuitpython/actions/runs/6540604996

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's try it

@tannewt tannewt merged commit 9f94b1b into adafruit:main Oct 17, 2023
@dhalbert dhalbert deleted the fix-mpy-cross-uploads branch October 17, 2023 16:41
@dhalbert
Copy link
Collaborator Author

Worked! Whew.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants