Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Unexpected Maker BlizzardS3 board for Espressif port. #8480

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Added Unexpected Maker BlizzardS3 board for Espressif port. #8480

merged 1 commit into from
Oct 15, 2023

Conversation

UnexpectedMaker
Copy link

Added UM Blizzard S3 board definitions

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test, but looks fine!

Could you submit another PR to main? Note that mpconfigboard.mk and sdkconfig have changed significantly in our 9.0.0 revamp of various things, so just merging this from 8.2.x is not going to work. Check out some examples of your current boards in main.

@dhalbert dhalbert merged commit 10a4424 into adafruit:8.2.x Oct 15, 2023
@UnexpectedMaker
Copy link
Author

Can't test, but looks fine!

Could you submit another PR to main? Note that mpconfigboard.mk and sdkconfig have changed significantly in our 9.0.0 revamp of various things, so just merging this from 8.2.x is not going to work. Check out some examples of your current boards in main.

Yeah, sure thing. It 9.0 close? I am working on adding 2 more boards at the moment, so do I just add them to main and not bother with 8.x?

@dhalbert
Copy link
Collaborator

Yeah, sure thing. It 9.0 close? I am working on adding 2 more boards at the moment, so do I just add them to main and not bother with 8.x?

9.0.0 is not that close. We are finishing the MicroPython v1.20.0 merge, and then we'll start doing alpha's, because the .mpy format will stop changing. But then we also need to do the v1.21.0 merge, and there's a lot of debugging to do too.

No issue if you want to wait and do all the boards at once for main.

@UnexpectedMaker
Copy link
Author

Yeah, sure thing. It 9.0 close? I am working on adding 2 more boards at the moment, so do I just add them to main and not bother with 8.x?

9.0.0 is not that close. We are finishing the MicroPython v1.20.0 merge, and then we'll start doing alpha's, because the .mpy format will stop changing. But then we also need to do the v1.21.0 merge, and there's a lot of debugging to do too.

No issue if you want to wait and do all the boards at once for main.

Ok, thanks for clarifying - I'll get all of the boards added for 8.2.x - I'm assuming there's going to be an 8.2.7 or more... and then I'll work on getting them ready for main as well.
Cheers :)

@dhalbert
Copy link
Collaborator

An 8.2.7 may be imminent, in a day or two. But there will probably be an 8.2.8 also. We will just keep going every few weeks on 8.2.x if there are interesting changes, including new boards.

@tannewt
Copy link
Member

tannewt commented Oct 16, 2023

I can update the board defs with the 8.2.x merge into main if needed.

@UnexpectedMaker
Copy link
Author

I can update the board defs with the 8.2.x merge into main if needed.

Thanks for the offer Scott :) but I should learn the differences, so I'll do them. I'm not quite ready with the other 2 boards yet anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants