-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine error message for rp2040 audiobusio I2S object creation #8466
Conversation
The error message for creating an I2S object on the rp2040 platform in CircuitPython can be misleading when the word_select and data pins are not sequential. This change updates the error message to provide clearer guidance by specifying "GPIO pins" instead of just "pins". The revised message now reads: ValueError: Bit clock and word select must be sequential GPIO pins Closes adafruit#8058 Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heygauri run make translate
locally, and then commit the resulting change to locale/circuitpython.pot
.
I followed the same process, and it updated the error message in locale/circuitpython.pot. However, it also generated some unintended changes, approximately -518 lines, which I am not aware of. You can see those changes in this PR. |
Update: I followed the document https://learn.adafruit.com/building-circuitpython/linux and below is the output: $ make translate |
The missing error messages are because the There were some new translations, so I merged from upstream (upon reflection, probably not necessary), re-did the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you for the help. |
The error message for creating an I2S object on the rp2040 platform in CircuitPython can be misleading when the word_select and data pins are not sequential. This change updates the error message to provide clearer guidance by specifying "GPIO pins" instead of just "pins". The revised message now reads:
ValueError: Bit clock and word select must be sequential GPIO pins
Closes #8058