Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated apis #8456

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Oct 2, 2023

This removes .show() in favor of .root_group = . One other spot for I2CPeripheral removed too.

@tannewt tannewt added this to the 9.0.0 milestone Oct 2, 2023
@tannewt tannewt requested a review from dhalbert October 2, 2023 21:42
@dhalbert
Copy link
Collaborator

dhalbert commented Oct 3, 2023

A few failing jobs.

@FoamyGuy
Copy link
Collaborator

FoamyGuy commented Oct 3, 2023

I ran this successfully on a Feather ESP32-S2 TFT and confirmed .root_group = is working as expected and show() no longer exists on Display.

I can try on rgbmatrix / framebuffer and eink but it will not be until later on tonight.

@tannewt
Copy link
Member Author

tannewt commented Oct 3, 2023

A few failing jobs.

Ok with a retry. Please take another look.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants