-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to ESP-IDF 5.1 and add C6 and H2 support #8424
Conversation
* Disable bleio on C3 with 4MB flash. * Fix gpio include path in board.c's that use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing us up to date!
Approving, but one q about INTERNAL_LIBM
. Merge when you wish.
@@ -2,7 +2,7 @@ | |||
INTERNAL_FLASH_FILESYSTEM = 1 | |||
|
|||
# Internal math library is substantially smaller than toolchain one | |||
INTERNAL_LIBM = 1 | |||
INTERNAL_LIBM = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you change this to use the ESP-IDF libm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a rom blob (can't remember which) that links against floor()
. Our implementation has it for doubles but it didn't compile. So, I switched it assuming that's what espressif uses.
_bleio
disabled to make plenty of room.