Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ESP-IDF 5.1 and add C6 and H2 support #8424

Merged
merged 8 commits into from
Sep 22, 2023

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Sep 22, 2023

  • H2 is the first ESP without wifi.
  • Code size grew so 2MB and 4MB C3s have _bleio disabled to make plenty of room.
  • GCC was updated so some changes are to fix new compiler errors.
  • adc and dac drivers were updated to new API. (C6 only supports new adc API.)
  • C6 and H2 have a new RTC peripheral, LP_AON, that is used in place of the RTC on those chips.

@tannewt tannewt added enhancement espressif applies to multiple Espressif chips labels Sep 22, 2023
@tannewt tannewt added this to the 9.0.0 milestone Sep 22, 2023
@tannewt tannewt requested a review from dhalbert September 22, 2023 17:15
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing us up to date!

Approving, but one q about INTERNAL_LIBM. Merge when you wish.

@@ -2,7 +2,7 @@
INTERNAL_FLASH_FILESYSTEM = 1

# Internal math library is substantially smaller than toolchain one
INTERNAL_LIBM = 1
INTERNAL_LIBM = 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change this to use the ESP-IDF libm?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a rom blob (can't remember which) that links against floor(). Our implementation has it for doubles but it didn't compile. So, I switched it assuming that's what espressif uses.

@tannewt tannewt merged commit 1c0155c into adafruit:main Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement espressif applies to multiple Espressif chips
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants