-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add memorymap support to RP2 port #8357
Conversation
CI found some breakage. I entirely missed the fact that there are multiple runtimes to consider when adding unsigned integer argument support. Also missed updating the nrf port with the uint32_t -> size_t change. Working... |
@tannewt over to you for review. Thanks! |
After tuning in to the meeting today my understanding of 8.2.x vs. main branch has improved. @tannewt would you like me to rework this pull request for 8.2.x? |
Only if you want to see it in an 8.x release. Otherwise it's fine on main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Just a couple questions/suggestions.
On second thought, let's leave this on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more minor things. Thanks for the updates!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you!
Resolves #8334 by adding memorymap support to the RP2 port. Also makes these additional changes: