Two small changes #8242
Merged
Two small changes #8242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Raise an exception when creating a USB device when host isn't initialized. 2. Mark RP2040 dtcm_bss as NOLOAD since it doesn't need to be loaded (just zeroed.) 3. Fix submodule location for ulab to Jeff's copy.
|
The need to change the ulab submodule seems weird, as the change was merged by |
Yup, weird. I think it may have to do with my submodules tracking the wrong branch. (Sync doesn't sync them.) I've reverted that bit. |
|
weirdly no ports were re-built despite the change in shared-module/usb/core/Device.c. This may be a problem with the build system I introduced and have hopefully now fixed in #8252. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix submodule location for ulab to Jeff's copy.