Add NeoPixel Library for Datanoise PicoADK. #8166
Conversation
There was a problem hiding this comment.
so the NeoPixel MPY should be included in the firmware.
This not in general a policy for boards. For Adafruit boards, we add frozen libraries for boards when we are worried about RAM space, which is not a worry on the RP2040. The disadvantage of freezing is that it uses up firmware space, and the library is frozen at a particular version. The user can override a frozen library by putting a version in /, instead of /lib, because sys.path by default is ['', '/', '.frozen', '/lib'].
However, this is just a guideline, and if you as a manufacturer want to freeze it, it's of course your choice. There are other third-party boards, particularly those designed for educational purposes, where the manufacturer has elected to freeze one or more libraries, including custom libraries for that board.
So happy to approve, based on your reaction to the above. Let us know.
|
@dhalbert My intention to freeze it was to include it in the base firmware, so it can be used by the PicoADK users. I think it is fine if we freeze it. |
The PicoADK has an WS2812-compatible addressable LED on board, so
the NeoPixel MPY should be included in the firmware.