Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add adafruit_qtpy_esp32s3_4mbflash_2mbpsram; remove frozen libs from qtpy_esp32s3_nopsram #8130

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Add adafruit_qtpy_esp32s3_4mbflash_2mbpsram; remove frozen libs from qtpy_esp32s3_nopsram #8130

merged 1 commit into from
Jul 11, 2023

Conversation

dhalbert
Copy link
Collaborator

@ladyada to test

  • Add adafruit_qtpy_esp32s3_4mbflash_2mbpsram.
  • Remove frozen modules from adafruit_qtpy_esp32s3_nopsram. They did not need to be frozen, and the corresponding Feather did not have these modules frozen. Probably a copy pasta mistake.

@dhalbert dhalbert requested a review from ladyada June 29, 2023 02:59
ladyada
ladyada approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with hardware - works gr8

@dhalbert dhalbert mentioned this pull request Jul 11, 2023
Closed
BlitzCityDIY
BlitzCityDIY approved these changes Jul 11, 2023
View reviewed changes
Copy link

@BlitzCityDIY BlitzCityDIY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested neopixel, digitalio, i2c and wifi and everything looks good!

@dhalbert dhalbert merged commit 5a7a7e2 into adafruit:main Jul 11, 2023
@dhalbert dhalbert deleted the adafruit_qtpy_esp32s3_4mbflash_2mbpsram branch July 11, 2023 17:05
@dhalbert dhalbert mentioned this pull request Jul 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

@BlitzCityDIY BlitzCityDIY BlitzCityDIY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhalbert @ladyada @BlitzCityDIY